Skip to content

Fix Trip Editor mobile bottom drawer#313

Merged
stef-k merged 31 commits into
mainfrom
fix/trip-editor-mobile-bottom-drawer-312
May 20, 2026
Merged

Fix Trip Editor mobile bottom drawer#313
stef-k merged 31 commits into
mainfrom
fix/trip-editor-mobile-bottom-drawer-312

Conversation

@stef-k
Copy link
Copy Markdown
Owner

@stef-k stef-k commented May 19, 2026

Scope

  • Phone-only map-first bottom drawer for the Trip Editor.
  • Trip / Regions / Segments tabs.
  • Reuses the existing editor state and draft model.
  • Preserves dirty prompts, validation, Save/Cancel/Delete, selection, search-add, and map-work behavior.
  • No backend/API changes.

Breakpoint

  • Drawer is scoped to max-width: 640px.
  • 641px, 700px, and 768px are protected as non-drawer widths.

Validation

  • npm run test:e2e:trip-editor: passed, 131 passed (4.6m).
  • Focused mobile drawer: npx playwright test --config=playwright.config.ts tests/e2e/trip-editor/tripEditorMobileDrawer.spec.ts: passed, 13 passed (25.3s).
  • npm run build: passed. Vite emitted the existing large chunk warning for main-go9yiDc7.js.
  • npx playwright test --config=playwright.config.ts --list: passed, listed 131 tests in 20 files.
  • dotnet run --project tools/Wayfarer.LocCheck -- --warn 400 --fail 600: passed with LOC warnings only, including tripEditorMobileDrawer.spec.ts (448 LOC) and existing Trip Editor files above the 400-line review threshold; no hard failures.
  • git diff --check origin/main...HEAD: passed.
  • Artifact scan: no tracked or untracked files under .local, playwright-report, test-results, screenshots, traces, wwwroot/vite/trip-editor, or wwwroot/dist.
  • Worktree clean before PR creation.

Pending before merge

  • Manual mobile screenshot review.
  • Asset smokes:
    • npm run smoke:trip-editor:assets:dev
    • npm run smoke:trip-editor:assets:published

Fixes #312

stef-k added 24 commits May 19, 2026 10:20
@stef-k stef-k merged commit b49962c into main May 20, 2026
1 check passed
@stef-k stef-k deleted the fix/trip-editor-mobile-bottom-drawer-312 branch May 20, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Trip Editor mobile map-first bottom-sheet layout

1 participant