Fix Trip Editor mobile bottom drawer#313
Merged
Merged
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Breakpoint
max-width: 640px.641px,700px, and768pxare protected as non-drawer widths.Validation
npm run test:e2e:trip-editor: passed,131 passed (4.6m).npx playwright test --config=playwright.config.ts tests/e2e/trip-editor/tripEditorMobileDrawer.spec.ts: passed,13 passed (25.3s).npm run build: passed. Vite emitted the existing large chunk warning formain-go9yiDc7.js.npx playwright test --config=playwright.config.ts --list: passed, listed131 tests in 20 files.dotnet run --project tools/Wayfarer.LocCheck -- --warn 400 --fail 600: passed with LOC warnings only, includingtripEditorMobileDrawer.spec.ts (448 LOC)and existing Trip Editor files above the 400-line review threshold; no hard failures.git diff --check origin/main...HEAD: passed..local,playwright-report,test-results,screenshots,traces,wwwroot/vite/trip-editor, orwwwroot/dist.Pending before merge
npm run smoke:trip-editor:assets:devnpm run smoke:trip-editor:assets:publishedFixes #312